Skip to content

fix: fix errors and typos #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 6, 2015
Merged

fix: fix errors and typos #465

merged 5 commits into from
Nov 6, 2015

Conversation

apapi
Copy link
Contributor

@apapi apapi commented Nov 5, 2015

No description provided.

@heathermiller
Copy link
Member

Thanks for your contribution. While I can't really comment on the Chinese fixes, "hash trie" in the English documentation is correct. Our HashMaps are backed by an efficient trie implementation... Could you drop the commits that rename Hash Tries? I assume the Chinese bits are correct :)

@SethTisue
Copy link
Member

@hepin1989 interested in helping review Chinese-language PRs like these? or know anybody who is?

@@ -146,11 +146,11 @@ If you want to create a range that is exclusive of its upper limit, then use the

Ranges are represented in constant space, because they can be defined by just three numbers: their start, their end, and the stepping value. Because of this representation, most operations on ranges are extremely fast.

## Hash Tries
## Hash Trees
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not change

@He-Pin
Copy link

He-Pin commented Nov 5, 2015

I have to say ,this translation is more like translated by mechine not by a human.
@apapi 中文翻译讲究信达雅,如果真的要维护官方文档的翻译,我觉得至少得达到上面的要求吧。

@SethTisue I have to say ,this translation is far form it's quality.

@He-Pin
Copy link

He-Pin commented Nov 5, 2015

I really don't know there is a Chinese translation,but I have to say ,thr current translation is not that good,and have some wrong translated.I want to improve that ,but just hard to find time.

@SethTisue
Copy link
Member

we'd certainly welcome additional fixes. every little bit helps.

@heathermiller
Copy link
Member

Given that both the Chinese and English improvements have issues, @SethTisue do you advise that we close? Or give @apapi a chance to remedy these issues?

@SethTisue
Copy link
Member

let's wait for @apapi.

also, I think @hepin1989's comments about the overall quality are about the translation as a whole, rather than about the quality of @apapi's edits to that translation. we could still accept @apapi's edits (if revised to reflect the feedback so far) as long as they are some kind of improvement.

@apapi
Copy link
Contributor Author

apapi commented Nov 6, 2015

@heathermiller thank you for educating me on HashMap implementation.
@hepin1989 I agree with you the overall quality of Chinese translation is poor. I just want to fix the type setting and obvious errors in these parts I have read.

SethTisue added a commit that referenced this pull request Nov 6, 2015
fix: fix errors and typos
@SethTisue SethTisue merged commit 57fc664 into scala:master Nov 6, 2015
@SethTisue
Copy link
Member

thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants